Curious what the initial contributor @valid-ptr thinks of this

Curious what the initial contributor @valid-ptr thinks of this

Nice PR.

It can be a good idea to add ${BACKENDS_PATH}/miniaudio/miniaudio.h to the BACKENDS_SOURCES also.
Then it will appear in the project (generated by cmake)

It can be a good idea to add ${BACKENDS_PATH}/miniaudio/miniaudio.h to the BACKENDS_SOURCES also. Then it will appear in the project (generated by cmake)

Forgive my unfamiliarity with cmake but is this necessary? soloud_miniaudio.cpp already includes miniaudio.h? It seems to work just fine without adding to the backend sources. Is there a non-functional reason to add that?

@jarikomppa any thoughts on this?

Header should be included because cmake can generate the project for Visual Studio or Xcode as instance.
The reason to include - is that the developer can access this header from IDE and at least can see that it's presented in the project.

PS
If you compile some program like
g++ main.cpp
you should not pass headers (which main.cpp uses) of course

PPS
Imaging the header-only library and how it will be presented in the IDE after cmake-generator phase ;^)

Header should be included because cmake can generate the project for Visual Studio or Xcode as instance. The reason to include - is that the developer can access this header from IDE and at least can see that it's presented in the project.

PS If you compile some program like g++ main.cpp you should not pass headers (which main.cpp uses) of course

PPS Imaging the header-only library and how it will be presented in the IDE after cmake-generator phase ;^)

Got it, thanks for the explanation! I went ahead and added it to BACKENDS_SOURCES

Bump?

Monthly Bump

Bi-annual Bump

I'm running into this issue using CMake, thanks for making this PR! I guess I'll switch to your fork until it gets merged.

I'm running into this issue using CMake, thanks for making this PR! I guess I'll switch to your fork until it gets merged.

Glad I could help!